Repository navigation
Conversation
WouterAms
force-pushed
the
bug/AM-1432-verander-vignet-vignette
branch
from
November 13, 2026 10:51
a331b63 to
c3053e5
Compare
github-actions
Bot
added
module:boat-charging
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human confirmation is needed that the backend /links response supplies boatChargingRequestVignette and boatChargingVignetteInfo, since backend evidence is unavailable and missing keys could disable the vignette links.
No open issues 🎉
What changed in this PR
Standardizes vignet to vignette in the boat-charging module’s English identifiers and related redirect keys, while preserving Dutch user-facing text.
Changes:
- Renames types, API hooks, routes, form fields, components, and test identifiers.
- Replaces old-named screens, action buttons, and alert mappings with renamed equivalents.
- Updates session initialization, confirmation, and navigation tests to use the new names.
| File | Description |
|---|---|
src/modules/redirects/exports/RedirectKey.ts |
Renames vignette redirect keys and values. |
src/modules/boat-charging/types.ts |
Renames vignette types, endpoints, and form fields. |
src/modules/boat-charging/service.ts |
Updates endpoint definitions and exported mutation hooks. |
src/modules/boat-charging/screens/BoatChargingVignette.screen.tsx |
Updates the management screen and route parameter. |
src/modules/boat-charging/screens/BoatChargingVerifyVignette.screen.tsx |
Adds the renamed verification screen. |
src/modules/boat-charging/screens/BoatChargingVerifyVignet.screen.tsx |
Removes the old-named verification screen. |
src/modules/boat-charging/screens/BoatChargingChooseVignette.screen.tsx |
Adds the renamed selection screen. |
src/modules/boat-charging/screens/BoatChargingChooseVignet.screen.tsx |
Removes the old-named selection screen. |
src/modules/boat-charging/screenConfig.ts |
Registers renamed screens and header button. |
src/modules/boat-charging/routes.ts |
Renames routes and vignette ID parameter. |
src/modules/boat-charging/providers/BoatChargingVignetteForm.provider.tsx |
Renames the form provider and number field. |
src/modules/boat-charging/hooks/useInitSessionNextStep.ts |
Updates field and route references. |
src/modules/boat-charging/hooks/useInitSessionNextStep.test.ts |
Updates fixtures and navigation expectations. |
src/modules/boat-charging/hooks/useInitSession.ts |
Reads the renamed session form field. |
src/modules/boat-charging/constants/vignetteInvalidReasonToAlertMap.ts |
Adds the renamed invalid-reason mapping. |
src/modules/boat-charging/constants/vignetInvalidReasonToAlertMap.ts |
Removes the old-named mapping. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignettePostalCodeFormInput.tsx |
Renames the component and test identifier. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetteNumberFormInput.tsx |
Renames the component, field, and test identifier. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormVerifyVignetteButton.tsx |
Adds the renamed verification button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormEditVignetteButton.tsx |
Adds the renamed edit button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormDeleteVignetteButton.tsx |
Adds the renamed delete button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormAddVignetteButton.tsx |
Adds the renamed add button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormAddToMyVignettesSwitch.tsx |
Updates component, type, and test identifier names. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetteForm.tsx |
Connects renamed controls, fields, and redirect key. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormVerifyVignetButton.tsx |
Removes the old-named verification button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormEditVignetButton.tsx |
Removes the old-named edit button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormDeleteVignetButton.tsx |
Removes the old-named delete button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormAddVignetButton.tsx |
Removes the old-named add button. |
src/modules/boat-charging/components/vignettes/form/BoatChargingChooseVignetteFormSubmitButton.tsx |
Updates selection submission and validation references. |
src/modules/boat-charging/components/vignettes/form/BoatChargingChooseVignetteForm.tsx |
Updates selection fields, navigation, and test identifiers. |
src/modules/boat-charging/components/vignettes/BoatChargingVignetteListItem.tsx |
Renames props and edit-navigation references. |
src/modules/boat-charging/components/vignettes/BoatChargingMyVignettes.tsx |
Uses renamed list items and add route. |
src/modules/boat-charging/components/vignettes/BoatChargingAddVignetteHeaderButton.tsx |
Renames the header button and navigation target. |
src/modules/boat-charging/components/session/BoatChargingSession.tsx |
Renames the vignette card’s test identifier. |
src/modules/boat-charging/components/BoatChargingHistorySessionDetails.tsx |
Renames the history card’s test identifier. |
src/modules/boat-charging/components/BoatChargingGuestEmailForm.tsx |
Updates pending selection and verification routes. |
src/modules/boat-charging/components/BoatChargingConfirmSessionSubmitButton.tsx |
Updates verification hooks, fields, and alert references. |
src/modules/boat-charging/components/BoatChargingConfirmSessionDetails.tsx |
Updates vignette details and change-navigation references. |
src/modules/boat-charging/alerts.ts |
Renames alert keys, test identifiers, and redirect reference. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Standardizes
vignettovignettein the boat-charging module’s English identifiers and related redirect keys, while preserving Dutch user-facing text.Changes:
src/modules/redirects/exports/RedirectKey.tssrc/modules/boat-charging/types.tssrc/modules/boat-charging/service.tssrc/modules/boat-charging/screens/BoatChargingVignette.screen.tsxsrc/modules/boat-charging/screens/BoatChargingVerifyVignette.screen.tsxsrc/modules/boat-charging/screens/BoatChargingVerifyVignet.screen.tsxsrc/modules/boat-charging/screens/BoatChargingChooseVignette.screen.tsxsrc/modules/boat-charging/screens/BoatChargingChooseVignet.screen.tsxsrc/modules/boat-charging/screenConfig.tssrc/modules/boat-charging/routes.tssrc/modules/boat-charging/providers/BoatChargingVignetteForm.provider.tsxsrc/modules/boat-charging/hooks/useInitSessionNextStep.tssrc/modules/boat-charging/hooks/useInitSessionNextStep.test.tssrc/modules/boat-charging/hooks/useInitSession.tssrc/modules/boat-charging/constants/vignetteInvalidReasonToAlertMap.tssrc/modules/boat-charging/constants/vignetInvalidReasonToAlertMap.tssrc/modules/boat-charging/components/vignettes/form/BoatChargingVignettePostalCodeFormInput.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetteNumberFormInput.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormVerifyVignetteButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormEditVignetteButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormDeleteVignetteButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormAddVignetteButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetteFormAddToMyVignettesSwitch.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetteForm.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormVerifyVignetButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormEditVignetButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormDeleteVignetButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingVignetFormAddVignetButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingChooseVignetteFormSubmitButton.tsxsrc/modules/boat-charging/components/vignettes/form/BoatChargingChooseVignetteForm.tsxsrc/modules/boat-charging/components/vignettes/BoatChargingVignetteListItem.tsxsrc/modules/boat-charging/components/vignettes/BoatChargingMyVignettes.tsxsrc/modules/boat-charging/components/vignettes/BoatChargingAddVignetteHeaderButton.tsxsrc/modules/boat-charging/components/session/BoatChargingSession.tsxsrc/modules/boat-charging/components/BoatChargingHistorySessionDetails.tsxsrc/modules/boat-charging/components/BoatChargingGuestEmailForm.tsxsrc/modules/boat-charging/components/BoatChargingConfirmSessionSubmitButton.tsxsrc/modules/boat-charging/components/BoatChargingConfirmSessionDetails.tsxsrc/modules/boat-charging/alerts.tsTest instructions
Other notes